Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

[CAD-1926] Retired pools should be ignored. #89

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

ksaric
Copy link
Contributor

@ksaric ksaric commented Oct 6, 2020

https://jira.iohk.io/browse/CAD-1926

Tested on qa-shelley.
Testing instructions. You first need to enable TESTING_MODE. When you do that you can check the existing metadata:

curl --verbose --header "Content-Type: application/json" http://localhost:3100/api/v1/metadata/fc80a2a814338475c737df5d1c50253046c8c04eb3663336af7beb38/93cf2f2fead6c419ccaae1a41f0786de4b9daefea7074d7bda3d288e76e20a97

Check the retired pools:

curl --verbose --header "Content-Type: application/json" http://localhost:3100/api/v1/retired

Then add a retired pool (simulate what the chain will do, this is why we need TESTING_MODE):

curl --verbose --header "Content-Type: application/json" --request PATCH --data '{"poolId":"fc80a2a814338475c737df5d1c50253046c8c04eb3663336af7beb38"}' http://localhost:3100/api/v1/retired

Now notice it's available in the list:

curl --verbose --header "Content-Type: application/json" http://localhost:3100/api/v1/retired

And you can no longer fetch the metadata:

curl --verbose --header "Content-Type: application/json" http://localhost:3100/api/v1/metadata/fc80a2a814338475c737df5d1c50253046c8c04eb3663336af7beb38/93cf2f2fead6c419ccaae1a41f0786de4b9daefea7074d7bda3d288e76e20a97

@ksaric
Copy link
Contributor Author

ksaric commented Oct 6, 2020

This PR addresses:

Once this is merged, they can be closed.

@ksaric ksaric merged commit b7fa2fe into master Oct 6, 2020
@iohk-bors iohk-bors bot deleted the ksaric/CAD-1926 branch October 6, 2020 19:05
@ksaric ksaric mentioned this pull request Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant