Batch Merkle Proof - override equals for matcher array equality #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for ergoplatform/ergo#1526
ScalaTest matchers do not properly evaluate
Array
contents as per scalatest/scalatest#491.Even when defining a custom
Equality[BatchMerkleProof]
trait, it does not get invoked when the target object is wrapped inside another container. This was causing problems in the Ergo Node PoPow serialization tests,As we are not using
BatchMerkleProof
inside any hash-based collections, I think we can avoid overriding hashcode as well?Open to any alternative suggestions.