Skip to content

fix: do not fail governance actions initiated by non-governance authority #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

LGLO
Copy link
Contributor

@LGLO LGLO commented Jun 25, 2025

Description

Scenario:

  • K1 wallet has funds, but K1 is not in governance authorities
  • K1 initiates some governance action and tx is created and awaiting signatures
  • B and C (governance authorities) sign tx

Before:

  • tx is signed by K1, B, and C, submission fails due too small fee
    After:
  • tx is signed by B and C only, submission succeeds

Ref: ETCM-11903

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • New code is documented and existing documentation is updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@LGLO LGLO force-pushed the ETCM-11903-multisig-offchain-fix branch from 007b88d to aa79412 Compare June 26, 2025 05:39
@LGLO LGLO enabled auto-merge (squash) June 26, 2025 05:40
@LGLO LGLO merged commit 030994c into master Jun 26, 2025
37 checks passed
@LGLO LGLO deleted the ETCM-11903-multisig-offchain-fix branch June 26, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants