-
Notifications
You must be signed in to change notification settings - Fork 19
change: ETCM-12049 extrinsic to delete SPO metadata #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klapeyron
reviewed
Jun 24, 2025
Klapeyron
reviewed
Jun 24, 2025
Klapeyron
reviewed
Jun 24, 2025
2ecfb4d
to
53bbd85
Compare
LGLO
reviewed
Jun 25, 2025
LGLO
reviewed
Jun 25, 2025
kpinter-iohk
approved these changes
Jun 25, 2025
Klapeyron
reviewed
Jun 25, 2025
Klapeyron
reviewed
Jun 25, 2025
LGLO
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Tomasz, that it will be simpler code and easier to understand when everything is in one map, but difference is so insignificant that I don't want to restrict PRs author freedom.
Klapeyron
reviewed
Jun 26, 2025
Klapeyron
reviewed
Jun 26, 2025
Klapeyron
reviewed
Jun 26, 2025
Klapeyron
reviewed
Jun 26, 2025
dc67043
to
d41dc92
Compare
Klapeyron
reviewed
Jun 26, 2025
Klapeyron
reviewed
Jun 26, 2025
Klapeyron
reviewed
Jun 26, 2025
Klapeyron
reviewed
Jun 26, 2025
iquerejeta
pushed a commit
that referenced
this pull request
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
delete_metadata
extrinsic to allow SPOs to clear their metadata and reclaim depositupsert
anddelete
subcommands; adds logic to sign deletion messageChecklist
changelog.md
for affected crate