Skip to content

change: ETCM-12049 extrinsic to delete SPO metadata #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 26, 2025

Conversation

AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Jun 24, 2025

Description

  • Adds logic to save depositor when creating SPO metadata
  • Changes the signed message to make the metadata field optional, so it can be reused for deletion
  • Adds a delete_metadata extrinsic to allow SPOs to clear their metadata and reclaim deposit
  • Splits the metadata signing CLI command into upsert and delete subcommands; adds logic to sign deletion message

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • New code is documented and existing documentation is updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@AmbientTea AmbientTea force-pushed the ETCM-12049-delete-metadata-extrinsic branch 2 times, most recently from 2ecfb4d to 53bbd85 Compare June 25, 2025 09:42
@AmbientTea AmbientTea marked this pull request as ready for review June 25, 2025 09:55
@kpinter-iohk kpinter-iohk self-requested a review June 25, 2025 11:41
@AmbientTea AmbientTea requested a review from LGLO June 25, 2025 12:36
Copy link
Contributor

@LGLO LGLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Tomasz, that it will be simpler code and easier to understand when everything is in one map, but difference is so insignificant that I don't want to restrict PRs author freedom.

@AmbientTea AmbientTea force-pushed the ETCM-12049-delete-metadata-extrinsic branch from dc67043 to d41dc92 Compare June 26, 2025 08:38
@AmbientTea AmbientTea merged commit 84e7f30 into master Jun 26, 2025
37 checks passed
@AmbientTea AmbientTea deleted the ETCM-12049-delete-metadata-extrinsic branch June 26, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants