Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCM-8596 query ogmios for network params instead of asking user for them #157

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

LGLO
Copy link
Contributor

@LGLO LGLO commented Oct 15, 2024

Description

This removes prompt for Cardano Network and optional query for custom parameters. It uses Ogmios and formulas to calculate values.
Cardano Network is now part of CaradanoParameters. Before it was only stored in the same place in JSON.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

Copy link
Contributor

@AmbientTea AmbientTea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge

@LGLO
Copy link
Contributor Author

LGLO commented Oct 16, 2024

huge

Huge mistake. Mine.

What should have been done instead is reading network magic from Ogmios and removing other variables, because they are configuration of db-sync-follower. So, db-sync-follower should look into postgres to self-configure and then we have the proper solution.

@LGLO
Copy link
Contributor Author

LGLO commented Oct 16, 2024

Anyway, I'll merge it, because it still is UX improvement. Depending on investigation of node being able to figure our these parameters it will be properly simplified.

@LGLO LGLO merged commit 857cd30 into master Oct 16, 2024
12 checks passed
@LGLO LGLO deleted the ETCM-8596-query-cardano-nework-parameters-from-ogmios branch October 16, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants