Fix metadata desynchronization #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevanspowell
force-pushed
the
feature/ADP-895-fix-desync
branch
from
06eace5 to
80ab948
Compare
sevanspowell
force-pushed
the
feature/ADP-915-decimals-minimal
branch
from
bb3c28e to
f7d5b7b
Compare
sevanspowell
changed the base branch from
feature/ADP-915-decimals-minimal
to
master
- Adds a script that queries the GH repository and sets the state of metadata database to match. - Add NixOS service. - Add integration tests that check that the write part of the script writes correctly, and doesn't touch the database at all if an exception occurs.
sevanspowell
force-pushed
the
feature/ADP-895-fix-desync
branch
from
68a6f13 to
8ebf937
Compare
- All NixOS module configurations allowed the configuration of user, but never actually used that option. Fix this to allow the user to configure the name of the user used when running the systemd service.
rvl
reviewed
May 21, 2021
Contributor
rvl
left a comment
rvl
left a comment
There was a problem hiding this comment.
So this is a script to slurp all the metadata json files from a registry git repo into the database?
Contributor
Author
|
Yep. And it exists because the webhook is flaky. A number of times a PR has been merged, a notification has been sent to the webhook, but then the webhook fails to retrieve the metadata entry from GitHub (usually it seems unable to reach the github API, but the reasons have varied). This leaves the Postgres database in a different state to the repo. This script is just a quick fix to that problem, because we don't have the time to dedicate to a proper solution. |
Contributor
|
OK fair enough. |
Contributor
Author
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 25, 2021
28: Fix metadata desynchronization r=sevanspowell a=sevanspowell - Adds a script that queries the GH repository and sets the state of metadata database to match. - Add NixOS service. - Add integration tests that check that the write part of the script writes correctly, and doesn't touch the database at all if an exception occurs. Co-authored-by: Samuel Evans-Powell <mail@sevanspowell.net>
|
Timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metadata database to match.
writes correctly, and doesn't touch the database at all if an
exception occurs.