Support for decimals #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevanspowell
force-pushed
the
feature/ADP-915-decimals-minimal
branch
from
58c6e49 to
dda3809
Compare
sevanspowell
force-pushed
the
feature/ADP-915-decimals-minimal
branch
from
12358b2 to
ba54e39
Compare
- Provide support for the decimals field in offchain-metadata-tools. - Add a test to demonstrate the existing behaviour that sequence numbers present in unknown properties are validated.
sevanspowell
force-pushed
the
feature/ADP-915-decimals-minimal
branch
from
ba54e39 to
83866da
Compare
Contributor
Author
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 13, 2021
23: Support for decimals r=sevanspowell a=sevanspowell ADP-915 - Provide support for the decimals field in offchain-metadata-tools. - Add a test to demonstrate the _**existing**_ behaviour that sequence numbers present in unknown properties are validated. Co-authored-by: Samuel Evans-Powell <mail@sevanspowell.net>
|
Canceled. |
Contributor
|
255 decimals? The first version had a maximum amount of 19 decimals, whats the decision behind going up to 255 decimals? |
Contributor
|
Hi @gitmachtl, thanks for the question. It was chosen as a maximum which basically means "no maximum." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADP-915