Fix build and import haskell.nix override #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was still some breakage due to overlay -> extras. The haskell.nix revision needed to be updated. I removed the overrideWith because it's not necessary here. The haskell lib can be overridden with normal function args.
This was referenced Mar 19, 2019
angerman
approved these changes
Mar 20, 2019
Collaborator
angerman
left a comment
angerman
left a comment
There was a problem hiding this comment.
I'm generally ok with this.
I do wonder however if we don't want to retain the -I haskell override, and if we want to use .json files similar to how we use them in all the other repos for consistency?
Contributor
Author
|
Use this instead: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was still some breakage due to
overlay→extras. The haskell.nix revision needed to be updated.I removed the
overrideWithbecause it's not necessary here. The haskell lib can be overridden with normal function args.