Skip to content

Signer deployment model #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 21, 2023
Merged

Signer deployment model #999

merged 4 commits into from
Jun 21, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 20, 2023 •
edited
Loading

Content

This PR includes:

  • the recommended deployment models for SPOs on the mainnet and preview/preprod
  • the optional usage of a relay with the signer

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

Issue(s)

Relates to #961

@jpraynaud jpraynaud self-assigned this Jun 20, 2023
@jpraynaud jpraynaud temporarily deployed to testing-preview June 20, 2023 16:51 — with GitHub Actions Inactive
Alenar
Alenar reviewed Jun 21, 2023
View reviewed changes
@jpraynaud jpraynaud force-pushed the jpraynaud/961-signer-deployment-model branch from 8c91662 to d2ce713 Compare June 21, 2023 10:05
@jpraynaud jpraynaud requested review from Alenar and ghubertpalo June 21, 2023 10:09
@jpraynaud jpraynaud temporarily deployed to testing-preview June 21, 2023 10:28 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 01bc281 into main Jun 21, 2023
@jpraynaud jpraynaud deleted the jpraynaud/961-signer-deployment-model branch June 21, 2023 15:05
@jpraynaud jpraynaud linked an issue Jun 21, 2023 that may be closed by this pull request
Design recommended deployment model for SPOs on mainnet and preview/preprod #961
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

+1 more reviewer

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design recommended deployment model for SPOs on mainnet and preview/preprod
3 participants
@jpraynaud @Alenar @ghubertpalo