Skip to content

Upgrade Rust outdated dependencies #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 16, 2023

Content

This PR includes an upgrade of the outdated Rust dependencies except for:

  • sqlite which requires a refactoring of the Cursor and Row
  • rand-chacha-dalek-compat which creates a build error error: the crate mithril-common v0.2.62 depends on crate rand_chacha v0.3.1 multiple times with different names

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Jun 16, 2023
@jpraynaud jpraynaud requested review from Alenar and ghubertpalo June 16, 2023 09:32
Except for 'sqlite' and 'rand-chacha-dalek-compat' (due to incompatibility error).
@jpraynaud jpraynaud force-pushed the jpraynaud/upgrade-rust-dependencies branch from d4a8e6f to b7e028e Compare June 16, 2023 09:39
@jpraynaud jpraynaud temporarily deployed to testing-preview June 16, 2023 09:50 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 404d63c into main Jun 16, 2023
@jpraynaud jpraynaud deleted the jpraynaud/upgrade-rust-dependencies branch June 16, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants