Skip to content

Fix snapshot download command error with --download-dir option in client #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2023
Merged

Fix snapshot download command error with --download-dir option in client #981

merged 2 commits into from
Jun 15, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jun 14, 2023 •
edited
Loading

Content

This PR includes a fix related to an error mentioned in #979 issue.
db_pathdir value was always empty and was an unwanted duplicate of unpack_dir as explained in the issue.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

MithrilClientSnapshotService config has been removed as it's no longer used.
All tests passed.

Issue(s)

Closes #979

jpraynaud
jpraynaud approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 2fc8a35 into input-output-hk:main Jun 15, 2023
@dlachaume dlachaume deleted the damien/979-fix-client-snapshot-command-with-download-dir-option branch July 13, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client snapshot download command fails with option --download-dir
3 participants
@dlachaume @jpraynaud @ghubertpalo