Skip to content

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jun 14, 2023

Content

This PR includes a fix related to an error mentioned in #979 issue.
db_pathdir value was always empty and was an unwanted duplicate of unpack_dir as explained in the issue.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

MithrilClientSnapshotService config has been removed as it's no longer used.
All tests passed.

Issue(s)

Closes #979

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 2fc8a35 into input-output-hk:main Jun 15, 2023
@dlachaume dlachaume deleted the damien/979-fix-client-snapshot-command-with-download-dir-option branch July 13, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client snapshot download command fails with option --download-dir

3 participants