Skip to content

Fix pruning panic #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2023
Merged

Fix pruning panic #856

merged 4 commits into from
Apr 6, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Apr 6, 2023 •
edited
Loading

Content

This PR includes a fix for panic that occurred during pruning:

  • Reactivate store retention on aggregator stores in infrastructure
  • Deactivate pruning on store adapter implementation of EpochSettingStore
  • Fix sort order problem on function get_last_n_records of SignerRegistrationStore

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #828

@jpraynaud jpraynaud self-assigned this Apr 6, 2023
@jpraynaud jpraynaud requested a review from ghubertpalo April 6, 2023 13:36
@jpraynaud jpraynaud force-pushed the jpraynaud/828-fix-pruning-panic-epoch-setting branch from 36494af to fe479dc Compare April 6, 2023 13:45
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Test Results

    3 files  ±0    30 suites  ±0   5m 59s ⏱️ -1s
522 tests ±0  522 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
598 runs  ±0  598 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fe479dc. ± Comparison against base commit f8f3434.

@jpraynaud jpraynaud temporarily deployed to testing-preview April 6, 2023 14:09 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit ca18af4 into main Apr 6, 2023
@jpraynaud jpraynaud deleted the jpraynaud/828-fix-pruning-panic-epoch-setting branch April 6, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpraynaud @ghubertpalo