Skip to content

#665 handling errors better #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 7, 2023
Merged

#665 handling errors better #776

merged 7 commits into from
Mar 7, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Feb 27, 2023 •
edited
Loading

Content

This PR adds better error handling in the Aggregator & Signer runtimes.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

None

Issue(s)

Closes #665

@github-actions
Copy link

github-actions bot commented Feb 27, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  +2   5m 57s ⏱️ +21s
446 tests +4  446 ✔️ +4  0 💤 ±0  0 ❌ ±0 
516 runs  +6  516 ✔️ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 43516f0. ± Comparison against base commit 52cef88.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo temporarily deployed to testing-preview February 27, 2023 10:28 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview February 28, 2023 09:46 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo temporarily deployed to testing-preview February 28, 2023 12:05 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo requested a review from jpraynaud March 1, 2023 08:33
@ghubertpalo ghubertpalo force-pushed the ensemble/665/runtime_error_handling branch from 72e16e8 to 259ae2d Compare March 2, 2023 17:01
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 2, 2023 18:06 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 6, 2023 11:24 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ghubertpalo and others added 6 commits March 7, 2023 09:43
@ghubertpalo ghubertpalo force-pushed the ensemble/665/runtime_error_handling branch from 60d2962 to 70aea85 Compare March 7, 2023 08:47
@ghubertpalo ghubertpalo force-pushed the ensemble/665/runtime_error_handling branch from 70aea85 to 43516f0 Compare March 7, 2023 08:59
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 7, 2023 09:11 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo merged commit fa2cf90 into main Mar 7, 2023
@ghubertpalo ghubertpalo deleted the ensemble/665/runtime_error_handling branch March 7, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@jpraynaud jpraynaud

@ghubertpalo ghubertpalo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add context to errors
2 participants
@ghubertpalo @jpraynaud