Skip to content

Add dynamic matrix in CI for end to end tests #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 22, 2023
Merged

Add dynamic matrix in CI for end to end tests #761

merged 3 commits into from
Feb 22, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Feb 21, 2023 •
edited
Loading

Content

This PR includes a dynamic generation of the matrix cases of the end to end tests in the CI. It now uses the list of available eras and combines them with the number of runs by era.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #760

@jpraynaud jpraynaud force-pushed the jpraynaud/760-ci-dynamic-matrix-eras branch 3 times, most recently from 540a978 to e1183a5 Compare February 21, 2023 11:28
@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited
Loading

Test Results

    3 files  ±0    28 suites  ±0   5m 51s ⏱️ +13s
441 tests ±0  441 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
509 runs  ±0  509 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0e369da. ± Comparison against base commit feb1e00.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/760-ci-dynamic-matrix-eras branch 13 times, most recently from b1354f6 to 0adac95 Compare February 21, 2023 16:43
@jpraynaud jpraynaud self-assigned this Feb 21, 2023
@jpraynaud jpraynaud force-pushed the jpraynaud/760-ci-dynamic-matrix-eras branch 5 times, most recently from 2d2b544 to abb90e4 Compare February 21, 2023 17:06
@jpraynaud
Fix enums serialization
c458c2d
@jpraynaud
Add dynamic matrix test lab
c1eefee 
The era is computed from the list of available Mithril eras in the binaries.
@jpraynaud jpraynaud force-pushed the jpraynaud/760-ci-dynamic-matrix-eras branch from abb90e4 to c1eefee Compare February 21, 2023 17:20
@jpraynaud jpraynaud marked this pull request as ready for review February 21, 2023 17:37
@jpraynaud jpraynaud temporarily deployed to testing-preview February 21, 2023 20:01 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit fd01c99 into main Feb 22, 2023
@jpraynaud jpraynaud deleted the jpraynaud/760-ci-dynamic-matrix-eras branch February 22, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make dynamic matrix in CI end to end
2 participants
@jpraynaud @ghubertpalo