Skip to content

Fix make errors from root v2 #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix make errors from root v2 #687

merged 1 commit into from
Jan 18, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 17, 2023

Content

This PR includes a better fix than the one provided in #684, and does not need to introduce a Makefile in the mithril-test-lab folder (which this PR removes)

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@github-actions
Copy link

github-actions bot commented Jan 17, 2023

Test Results

    3 files  ±0    28 suites  ±0   6m 6s ⏱️ +38s
386 tests ±0  386 ✔️ ±0  0 💤 ±0  0 ±0 
447 runs  ±0  447 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5781da8. ± Comparison against base commit f3107a5.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview January 17, 2023 09:37 — with GitHub Actions Inactive
@jpraynaud jpraynaud self-assigned this Jan 17, 2023
@jpraynaud jpraynaud temporarily deployed to testing-preview January 18, 2023 11:56 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview January 18, 2023 12:13 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview January 18, 2023 12:22 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/fix-make-build-2 branch from 99d505b to 5781da8 Compare January 18, 2023 13:18
@jpraynaud jpraynaud temporarily deployed to testing-preview January 18, 2023 13:39 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 8096196 into main Jan 18, 2023
@jpraynaud jpraynaud deleted the jpraynaud/fix-make-build-2 branch January 18, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants