Skip to content

Update rust dependencies #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2022
Merged

Update rust dependencies #583

merged 3 commits into from
Nov 4, 2022

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Nov 3, 2022 •
edited
Loading

Content

This PR updates rust dependencies & the global cargo lock.

It also contains a CI improvement: Avoid recompilation when macking Debian packages using cargo deb

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@Alenar
Copy link
Collaborator Author

Alenar commented Nov 3, 2022

@iquerejeta I took the liberty to update the digest dependency in mithril-core (from 0.9.0 to 0.10.5), is that ok for you ?

jpraynaud
jpraynaud approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
If @iquerejeta is OK with the digest upgrade

@github-actions
Copy link

github-actions bot commented Nov 3, 2022 •
edited
Loading

Unit Test Results

    3 files  ±0    28 suites  ±0   3m 4s ⏱️ -17s
326 tests ±0  326 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
379 runs  ±0  379 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 64661a5. ± Comparison against base commit cbb5d83.

♻️ This comment has been updated with latest results.

@jpraynaud
Fix clippy warnings
64661a5 
Following release of rust 1.65.0
@jpraynaud jpraynaud temporarily deployed to testing-preview November 3, 2022 16:51 Inactive
iquerejeta
iquerejeta approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar merged commit 4f03dab into main Nov 4, 2022
@Alenar Alenar deleted the djo/update-deps branch November 4, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@iquerejeta iquerejeta iquerejeta approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alenar @jpraynaud @iquerejeta