Skip to content

Fix KES key update #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Fix KES key update #569

merged 5 commits into from
Oct 26, 2022

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 25, 2022

Content

This PR includes a fix that updates KES keys to the current period:
kes_period = current_kes_period - start_kes_period

We still verify the full range of KES period for backward compatibility and until the preview network is respin

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Comments

In order to use the correct KES period, we need to manually evolve the key (as it is done in memory on the Cardano node)

Contributors

Issue(s)

Relates to #548

@github-actions
Copy link

github-actions bot commented Oct 25, 2022

Unit Test Results

    7 files  ±0    22 suites  ±0   2m 7s ⏱️ -2s
322 tests ±0  322 ✔️ ±0  0 💤 ±0  0 ±0 
323 runs  ±0  323 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 458ad73. ± Comparison against base commit fec5db3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 4456966 into main Oct 26, 2022
@jpraynaud jpraynaud deleted the ensemble/548-fix-kes-period-issue branch October 26, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants