Skip to content

add API version in HTTP headers #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2022
Merged

add API version in HTTP headers #566

merged 3 commits into from
Nov 15, 2022

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Oct 24, 2022

Content

This patch adds a new HTTP response header that advertise the version of the Mithril Protocol supported by the server.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #565

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

Unit Test Results

    3 files  ±0    28 suites  ±0   2m 33s ⏱️ -20s
326 tests ±0  326 ✔️ ±0  0 💤 ±0  0 ±0 
379 runs  ±0  379 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8e45da1. ± Comparison against base commit 9714e2c.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo force-pushed the greg/565/api_version branch 2 times, most recently from 99b1d67 to ad6d27e Compare October 25, 2022 09:13
The protocol version is indicated in the `openapi.yml` file must also be
up to date at compile time in the Rust source code. For now, a comment
to link the Rust constant to the YAML version has been made.
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo temporarily deployed to testing-preview November 14, 2022 17:09 Inactive
@ghubertpalo ghubertpalo merged commit c219cfd into main Nov 15, 2022
@ghubertpalo ghubertpalo deleted the greg/565/api_version branch November 15, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants