Skip to content

Fix Multi Signature Determinism #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

jpraynaud
Copy link
Member

The multi signature was not deterministically generated and 2 runs created 2 different values

The multi signature was not deterministicaly generated and 2 runs created 2 different values
@jpraynaud jpraynaud requested a review from iquerejeta August 22, 2022 15:58
Copy link
Contributor

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

Unit Test Results

    7 files  ±0    22 suites  ±0   3m 59s ⏱️ -22s
287 tests ±0  287 ✔️ ±0  0 💤 ±0  0 ±0 
288 runs  ±0  288 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit d7365e4. ± Comparison against base commit f95f565.

@jpraynaud jpraynaud merged commit d9b29e5 into main Aug 22, 2022
@jpraynaud jpraynaud deleted the jpraynaud/fix-multisig-non-deterministic branch August 22, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants