-
Notifications
You must be signed in to change notification settings - Fork 44
Implement Real Genesis Certificate #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 7 files ± 0 22 suites ±0 2m 3s ⏱️ -24s Results for commit c0e1cff. ± Comparison against base commit 3f9a99a. This pull request removes 7 and adds 31 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
55b95dd
to
8eef101
Compare
Base automatically changed from
jpraynaud/364-move-certificate-verifier-to-common
to
main
August 22, 2022 11:38
4334052
to
5a84d9f
Compare
Closed
c816bc7
to
30a2a01
Compare
6843e7c
to
d6fe5f3
Compare
Modify the state machine so that it can handle the case where certificate chain is not valid but we still need to update stake distribution and protocol parameters at each epoch
With deterministic RNG for tests and non deterministic RNG to use for testnet
This route is mandatory to enable the registration of the Signers before boostraping the genesis certificate of the chain
In transtion from REGISTERED to SIGNED in Aggregator
And use the correct beacon so that stake distribution and protocol parameters are really updated on next cycle when epoch changes
By replacing the wait for a pending certificate by a wait for epoch settings, as pending certificates are not always available
Of the Aggregator and the Client nodes
b32a325
to
c0e1cff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
Real Genesis Certificate
:Genesis Signer
that signs a message with aGenesis Secret Key
(only for test purpose)Genesis Verifier
that verifies aGenesis Signature
against aGenesis Verification Key
verify_genesis_certificate
of theCertificate Verifier
Genesis Verification Key
Genesis Verification Key
Certificate Chain
is valid before trying to produce newMithril Certificates
Genesis Keys
, and boostrap a test onlyGenesis Certificate
Genesis Secret Key
into aGenesis Signature
Genesis Signature
and create aGenesis Certificate
test lab
to bootstrap aGenesis Certificate
devnet
standalone to bootstrap aGenesis Certificate
Genesis Keys
Closes #364