Skip to content

Attempt fix CI flakiness #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Attempt fix CI flakiness #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea64a18
Rollback end to end specs with Stake Distribution update
jpraynaud Aug 10, 2022
effa780
Update CI matrix test lab
jpraynaud Aug 17, 2022
46069ec
Update runtime interval devnet/end to end
jpraynaud Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ jobs:
run-test-lab:
runs-on: ubuntu-latest
needs: [ build ]
strategy:
fail-fast: false
matrix:
run_id: [0,1,2,3,4,5,6,7,8,9]
steps:
- name: Checkout sources
uses: actions/checkout@v2
Expand Down Expand Up @@ -247,7 +251,7 @@ jobs:
if: ${{ failure() }}
uses: actions/upload-artifact@v3
with:
name: mithril-e2e-tests-artifacts-run_${{ github.run_number }}-attempt_${{ github.run_attempt }}
name: mithril-e2e-tests-artifacts-run_run_id_${{ matrix.run_id }}_${{ github.run_number }}-attempt_${{ github.run_attempt }}
path: |
./artifacts/*
# including node.sock makes the upload fails so exclude them:
Expand Down
2 changes: 1 addition & 1 deletion mithril-test-lab/mithril-devnet/devnet-mkfiles.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ cat >> docker-compose.yaml <<EOF
- PROTOCOL_PARAMETERS__K=5
- PROTOCOL_PARAMETERS__M=100
- PROTOCOL_PARAMETERS__PHI_F=0.65
- RUN_INTERVAL=1000
- RUN_INTERVAL=500
- URL_SNAPSHOT_MANIFEST=
- SNAPSHOT_STORE_TYPE=local
- SNAPSHOT_UPLOADER_TYPE=local
Expand Down
11 changes: 8 additions & 3 deletions mithril-test-lab/mithril-end-to-end/src/end_to_end_spec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,13 @@ impl Spec {
"epoch after which the stake distribution will change".to_string(),
)
.await?;
let digest = assert_node_producing_snapshot(&aggregator_endpoint).await?;
let certificate_hash =
assert_signer_is_signing_snapshot(&aggregator_endpoint, &digest, target_epoch - 1)
.await?;
assert_is_creating_certificate(&aggregator_endpoint, &certificate_hash).await?;
delegate_stakes_to_pools(self.infrastructure.devnet()).await?;
let target_epoch = min_epoch + 4;
let target_epoch = min_epoch + 8;
wait_for_target_epoch(
self.infrastructure.chain_observer(),
target_epoch,
Expand All @@ -50,7 +55,7 @@ impl Spec {
.await?;
let digest = assert_node_producing_snapshot(&aggregator_endpoint).await?;
let certificate_hash =
assert_signer_is_signing_snapshot(&aggregator_endpoint, &digest, target_epoch - 2)
assert_signer_is_signing_snapshot(&aggregator_endpoint, &digest, target_epoch - 1)
.await?;
assert_is_creating_certificate(&aggregator_endpoint, &certificate_hash).await?;

Expand Down Expand Up @@ -145,7 +150,7 @@ async fn wait_for_target_epoch(
"target_epoch" => ?target_epoch
);

match attempt!(90, Duration::from_millis(1000), {
match attempt!(120, Duration::from_millis(1000), {
match chain_observer.get_current_epoch().await {
Ok(Some(epoch)) => {
if epoch >= target_epoch {
Expand Down
2 changes: 1 addition & 1 deletion mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ impl Aggregator {
("PROTOCOL_PARAMETERS__K", "5"),
("PROTOCOL_PARAMETERS__M", "100"),
("PROTOCOL_PARAMETERS__PHI_F", "0.65"),
("RUN_INTERVAL", "600"),
("RUN_INTERVAL", "100"),
("URL_SNAPSHOT_MANIFEST", ""),
("SNAPSHOT_STORE_TYPE", "local"),
("SNAPSHOT_UPLOADER_TYPE", "local"),
Expand Down