Improve aggregator dependencies management #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving the RwLock directly inside the MemoryBeaconStore.
A RwLock was only needed by the DumbSnapshotUploader that ... already used one.
By moving the RwLock directly inside the only implementation that needed it (LocalSnapshotStore).
By moving the RwLock directly inside it.
By moving the RwLock directly inside it.
By moving the RwLock directly inside it.
By moving the RwLock directly inside it.
…erver dependencies By moving the RwLock directly inside it.
A dependency should not be optionnal if it's feature is mandatory, this heavely simplify the use of the DependencyManager.
Alenar
force-pushed
the
djo/improve_aggregator_dependencies_management
branch
from
e8d900d to
cb959d7
Compare
ghubertpalo
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RwLockcreation & management inside the trait implementations when needed instead of using them on the whole traits.Optionin theDependencyManager, heavily simplifying its usage.