Skip to content

Greg/250/chain observer #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2022
Merged

Greg/250/chain observer #294

merged 6 commits into from
Jun 24, 2022

Conversation

ghubertpalo
Copy link
Collaborator

Use a degraded chain observer for now. This Observer will always return the same fake stake distribution but the epoch should be accurate.

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Unit Test Results

218 tests  +1   218 ✔️ +1   7m 4s ⏱️ - 1m 23s
  17 suites ±0       0 💤 ±0 
    6 files   ±0       0 ±0 

Results for commit acb5f4a. ± Comparison against base commit 586a9da.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
chain_observer::cli_observer::tests ‑ test_get_current_stake_distribution
beacon_provider::tests ‑ test_beacon_error
beacon_provider::tests ‑ test_beacon_ok

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo requested review from jpraynaud and Alenar and removed request for jpraynaud June 23, 2022 15:48
@ghubertpalo ghubertpalo force-pushed the greg/250/chain-observer branch from deb2b95 to 5161bf9 Compare June 24, 2022 10:20
@ghubertpalo ghubertpalo requested a review from jpraynaud June 24, 2022 10:53
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo merged commit 8b0e442 into main Jun 24, 2022
@ghubertpalo ghubertpalo deleted the greg/250/chain-observer branch June 24, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants