Skip to content

Switch 'PartyId' to new type compatible with 'PoolId' #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 22, 2022
Merged

Switch 'PartyId' to new type compatible with 'PoolId' #289

merged 5 commits into from
Jun 22, 2022

Conversation

jpraynaud
Copy link
Member

This PR updates the underlying type of the PartyId to be able to store a Cardano node PoolId string:

  • Switch the party_id: u64 with party_id: String in open-api.yaml
  • Switch the party_id: u64 with party_id: String in mithril-common
  • Switch the party_id: u64 with party_id: String in mithril-aggregator
  • Switch the party_id: u64 with party_id: String in mithril-signer
  • Switch the party_id: u64 with party_id: String in protocol-demo

Closes #276

@github-actions
Copy link

Unit Test Results

208 tests  ±0   208 ✔️ ±0   8m 14s ⏱️ + 1m 16s
  17 suites ±0       0 💤 ±0 
    6 files   ±0       0 ❌ ±0 

Results for commit 945edd4. ± Comparison against base commit a768c45.

@jpraynaud jpraynaud marked this pull request as ready for review June 22, 2022 14:33
@jpraynaud jpraynaud requested review from ghubertpalo and Alenar June 22, 2022 14:33
@jpraynaud jpraynaud merged commit 1cf8186 into main Jun 22, 2022
@jpraynaud jpraynaud deleted the jpraynaud/276-party_id-new-type branch June 22, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@Alenar Alenar Awaiting requested review from Alenar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle the poolId along with party_id in Core/Aggregator/Signer
2 participants
@jpraynaud @ghubertpalo