Skip to content

Use offsetted epochs in Mithril Aggregator/Signer #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 7, 2022

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 21, 2022

Ths PR prepares the work to use an epoch offset for:

  • verification_key store in Mithril Aggregator
  • stake store in Mithril Aggregator and Mithril Signer

The epoch offset is fixed at compile time with the mithril_common::SIGNER_EPOCH_RETRIEVAL_OFFSET constant.

⚠️ Its value is currently set to 0 and will be updated to -1 when the Certificate Chain is implemented.

Relates to #250 and #316

@github-actions
Copy link

github-actions bot commented Jun 21, 2022

Unit Test Results

228 tests  ±0   228 ✔️ ±0   7m 23s ⏱️ -54s
  18 suites ±0       0 💤 ±0 
    6 files   ±0       0 ±0 

Results for commit 594a762. ± Comparison against base commit 414614e.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud marked this pull request as ready for review June 21, 2022 16:44
@jpraynaud jpraynaud requested review from ghubertpalo and Alenar June 21, 2022 16:45
@jpraynaud jpraynaud force-pushed the jpraynaud/250-use-offsetted-epochs branch from f850a50 to 080bdbd Compare June 22, 2022 08:44
@jpraynaud jpraynaud force-pushed the jpraynaud/250-chain-observer branch from f44dfc6 to bdbdabf Compare June 22, 2022 09:25
Base automatically changed from jpraynaud/250-chain-observer to main June 22, 2022 09:45
@jpraynaud jpraynaud force-pushed the jpraynaud/250-use-offsetted-epochs branch 3 times, most recently from 7c257bb to 5c81656 Compare June 23, 2022 15:25
jpraynaud added 6 commits July 7, 2022 16:15
For verification keys and stake distribution stores
In Aggregator and Signer nodes
In order to merge the attached PR. When the time has come, we will activate the epoch offset
That were not working anymore after rebasing the branch
@jpraynaud jpraynaud force-pushed the jpraynaud/250-use-offsetted-epochs branch from 5c81656 to 594a762 Compare July 7, 2022 15:06
@jpraynaud jpraynaud merged commit 859db5d into main Jul 7, 2022
@jpraynaud jpraynaud deleted the jpraynaud/250-use-offsetted-epochs branch July 7, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants