fix(ci): reactivate Darwin x86_64 build in Hydra CI

[jpraynaud]

Content

This PR reactivates the build for Darwin x86_64 in the Hydra CI.

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested

Issue(s)

Relates to #2250

[michalrus]

Thank you!

[github-actions]

Test Results

    3 files  ±0     77 suites  ±0   15m 16s ⏱️ +21s
1 940 tests ±0  1 940 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 292 runs  ±0  3 292 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d79aa04. ± Comparison against base commit 52fff48.

♻️ This comment has been updated with latest results.

[michalrus]

I see that some tests are failing for x86_64-darwin:

---- aggregator_client::tests::test_client_handle_404_not_found_error stdout ----

thread 'aggregator_client::tests::test_client_handle_404_not_found_error' panicked at mithril-client/src/aggregator_client.rs:822:9:
assertion `left == right` failed
  left: "RemoteServerLogical(Unhandled error 400 Bad Request: )"
 right: "RemoteServerLogical(Url='http://127.0.0.1:53203/certificates' not found)"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[jpraynaud]

I see that some tests are failing for x86_64-darwin:

---- aggregator_client::tests::test_client_handle_404_not_found_error stdout ----

thread 'aggregator_client::tests::test_client_handle_404_not_found_error' panicked at mithril-client/src/aggregator_client.rs:822:9:
assertion `left == right` failed
  left: "RemoteServerLogical(Unhandled error 400 Bad Request: )"
 right: "RemoteServerLogical(Url='http://127.0.0.1:53203/certificates' not found)"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@michalrus it looks like running a test HTTP server is not working on the Hydra CI runners.
I have successfully ran them on my local x86_64 Mac Book Pro in debug mode, but they fail as soon as I run them in release mode and produce the same errors as on the CI runs 🤔

[michalrus]

@jpraynaud nice, the last change worked, but now Linux is slightly broken when building tikv-jemalloc-sys?

  src/malloc_io.c: In function 'buferror':
  src/malloc_io.c:107:16: error: returning 'char *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
    107 |         return strerror_r(err, buf, buflen);
        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  make: *** [Makefile:480: src/malloc_io.sym.o] Error 1

I don't see how that's related to this PR. 😮

[jpraynaud]

@jpraynaud nice, the last change worked, but now Linux is slightly broken when building tikv-jemalloc-sys?

  src/malloc_io.c: In function 'buferror':
  src/malloc_io.c:107:16: error: returning 'char *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
    107 |         return strerror_r(err, buf, buflen);
        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  make: *** [Makefile:480: src/malloc_io.sym.o] Error 1

I don't see how that's related to this PR. 😮

This is likely due to the machine running the job. I restarted the jobs that were failing.

Also I fixed the other problem, so as soon as the CI is all green, I will merge the PR 👍

[michalrus]

Thank you!