-
Notifications
You must be signed in to change notification settings - Fork 44
Test: add Cardano node startup check to Mithril Client multi-platform test
workflow
#2476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: add Cardano node startup check to Mithril Client multi-platform test
workflow
#2476
Conversation
08426a6
to
7a7aa72
Compare
7a7aa72
to
9deb903
Compare
5fbdcbd
to
9deb903
Compare
9deb903
to
212a4d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I've a question: does the check against the cardano node is quick enough when running without the ancillary ? In that case the node must reconstruct the ledger and I fear that the added overhead make it too slow (plus maybe only checking with ancillary is enough ?).
dfc79c7
to
d6ff027
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…pshot command output
…ut ancillary files, and verify Cardano node startup (Linux only, client binary)
d6ff027
to
b676524
Compare
You're absolutely right, without the ancillary, the ledger state reconstruction is time-consuming. That's why we've implemented two verification steps: Without ancillary: We only check that the node starts opening the Immutable DB. This ensures that the necessary files are present to initiate the process. This check is quick and completes within the first 15 seconds. With ancillary: In addition to the previous check, we verify that the node has received a new valid block, confirming that it's actively running and extending its chain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Content
This PR includes enhancements for testing the
mithril-client
CLI across multiple platforms (Linux, macOS, Windows, and Docker), with or without ancillary files.It also includes (Linux only and client binary):
Started opening Immutable DB
(with a15s
timeout).Chain extended, new tip
is present (with a30s
timeout).Pre-submit checklist
Issue(s)
Closes #2471