Skip to content

Add warning in client about ancillary files #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

Add warning in client about ancillary files #2473

merged 3 commits into from
May 14, 2025
+193 −18

Conversation

turmelclem
Copy link
Collaborator

@turmelclem turmelclem commented May 12, 2025 •
edited
Loading

Content

Objective is to warn users using Client CLI and Client library that :

  • ancillary files are not signed by Mithril
  • without including ancillary files, fast bootstrap will not be available

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2459

@github-actions GitHub Actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

Test Results

    3 files     57 suites   11m 48s ⏱️
1 908 tests 1 908 ✅ 0 💤 0 ❌
2 388 runs  2 388 ✅ 0 💤 0 ❌

Results for commit 11c5ae7.

♻️ This comment has been updated with latest results.

@turmelclem turmelclem force-pushed the ctl/2459/Add_warning_in_client_when_not_downloading_ancillary_files branch 5 times, most recently from e5e1a53 to 061f1b7 Compare May 12, 2025 13:43
@turmelclem turmelclem changed the title WIP: add warning in client when not downloading ancillary files Add warning in client about ancillary files May 12, 2025
@turmelclem turmelclem temporarily deployed to testing-preview May 12, 2025 13:52 — with GitHub Actions Inactive
@turmelclem turmelclem force-pushed the ctl/2459/Add_warning_in_client_when_not_downloading_ancillary_files branch from 061f1b7 to d239b00 Compare May 12, 2025 13:55
@turmelclem turmelclem temporarily deployed to testing-preview May 12, 2025 14:04 — with GitHub Actions Inactive
@turmelclem turmelclem force-pushed the ctl/2459/Add_warning_in_client_when_not_downloading_ancillary_files branch from d239b00 to 1f36130 Compare May 13, 2025 12:05
@turmelclem turmelclem temporarily deployed to testing-preview May 13, 2025 12:14 — with GitHub Actions Inactive
@turmelclem turmelclem force-pushed the ctl/2459/Add_warning_in_client_when_not_downloading_ancillary_files branch from 1f36130 to b8a3703 Compare May 13, 2025 12:47
jpraynaud
jpraynaud reviewed May 13, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I left few comments below.

dlachaume
dlachaume approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, just a few minor comments.

@turmelclem turmelclem force-pushed the ctl/2459/Add_warning_in_client_when_not_downloading_ancillary_files branch from b8a3703 to 2a77ea5 Compare May 13, 2025 13:58
@turmelclem turmelclem temporarily deployed to testing-preview May 13, 2025 14:56 — with GitHub Actions Inactive
@turmelclem turmelclem force-pushed the ctl/2459/Add_warning_in_client_when_not_downloading_ancillary_files branch 2 times, most recently from f57697a to 235bd9f Compare May 13, 2025 15:43
@turmelclem turmelclem temporarily deployed to testing-preview May 13, 2025 15:57 — with GitHub Actions Inactive
@turmelclem turmelclem self-assigned this May 13, 2025
turmelclem added 3 commits May 14, 2025 11:24
@turmelclem
feat: print in Cardano DB v1 and v2 client-cli if ancillary files not…
0a7d0da 
… included
@turmelclem
feat: add warning about ancilary fast boostrap feature and signature …
2cddffa 
…origin in client library
@turmelclem
chore: upgrade crate versions
11c5ae7 
* mithril-client-cli from `0.12.1` to `0.12.2`
* mithril-client from `0.12.2` to `0.12.3`
@turmelclem turmelclem force-pushed the ctl/2459/Add_warning_in_client_when_not_downloading_ancillary_files branch from 235bd9f to 11c5ae7 Compare May 14, 2025 09:26
@turmelclem turmelclem temporarily deployed to testing-preview May 14, 2025 09:36 — with GitHub Actions Inactive
@turmelclem turmelclem merged commit 02cc3b9 into main May 14, 2025
38 checks passed
@turmelclem turmelclem deleted the ctl/2459/Add_warning_in_client_when_not_downloading_ancillary_files branch May 14, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud left review comments

@Alenar Alenar Alenar approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@turmelclem turmelclem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add warning in client when not downloading ancillary files
4 participants
@turmelclem @Alenar @jpraynaud @dlachaume