Skip to content

Feat: support GCP KMS ancillary signature in infrastructure #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 28, 2025

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Apr 22, 2025

Content

This PR includes the support for GCP KMS ancillary signature in infrastructure:

  • Terraform scripts have been modified to support custom ancillary signature
  • Terraform deployments have been modified in the CI to support custom ancillary signature
  • Ancillary verification keys have been created in the infrastructure
  • Network configurations have been updated in the documentation website

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2362

@jpraynaud jpraynaud self-assigned this Apr 22, 2025
Copy link

github-actions bot commented Apr 22, 2025

Test Results

    3 files  ±0     57 suites  ±0   11m 52s ⏱️ +16s
1 875 tests ±0  1 875 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 337 runs  ±0  2 337 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8a9abc8. ± Comparison against base commit e7358f2.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2362-ancillary-signature-infra branch from 346f0bf to 98ee721 Compare April 22, 2025 15:58
@jpraynaud jpraynaud force-pushed the jpraynaud/2362-ancillary-signature-infra branch from 98ee721 to 6aa4fdf Compare April 24, 2025 13:07
@jpraynaud jpraynaud force-pushed the jpraynaud/2362-ancillary-signature-infra branch from 0517e5c to 8f47f36 Compare April 24, 2025 13:59
@jpraynaud jpraynaud force-pushed the jpraynaud/2362-ancillary-signature-infra branch from 8f47f36 to f502bba Compare April 24, 2025 14:49
@jpraynaud jpraynaud force-pushed the jpraynaud/2362-ancillary-signature-infra branch from f502bba to 89ea25d Compare April 24, 2025 15:03
@jpraynaud jpraynaud temporarily deployed to testing-preview April 24, 2025 15:13 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 25, 2025 08:52 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview April 25, 2025 09:07 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 25, 2025 09:10 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 25, 2025 09:20 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2362-ancillary-signature-infra branch from a9c9773 to 87581ff Compare April 25, 2025 09:23
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 25, 2025 09:23 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview April 25, 2025 09:32 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2362-ancillary-signature-infra branch from 42214ce to 8a9abc8 Compare April 28, 2025 11:24
@jpraynaud jpraynaud temporarily deployed to testing-preview April 28, 2025 11:52 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 85f3bc7 into main Apr 28, 2025
41 of 43 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2362-ancillary-signature-infra branch April 28, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants