Skip to content

Reduce flakiness in the ci #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2025
Merged

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Mar 13, 2025

Content

The flakiness comes from the use of the same temporary directory by different tests.

This PR includes:

  • the creation of macros temp_dir that return a temporary path build from the current function path
  • the creation of macros temp_dir_create that create and return a temporary path build from the current function path
  • the addition of a new parameter to new_sample to indicate the snapshot directory.
  • creation of a macro initialize_dependencies that call the function with current module and current function name.
  • in tests, replacement uses the initialize_dependencies function to use initialize_dependencies! macro.
  • adaptation of the tests using new_sample to pass a temporary path generated using temp_dir!

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2360

Copy link

github-actions bot commented Mar 13, 2025

Test Results

    3 files  ±0     56 suites  ±0   11m 38s ⏱️ +13s
1 742 tests +7  1 742 ✅ +7  0 💤 ±0  0 ❌ ±0 
2 140 runs  +7  2 140 ✅ +7  0 💤 ±0  0 ❌ ±0 

Results for commit af37a52. ± Comparison against base commit 224d552.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-preview March 13, 2025 14:28 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the sfa/2360/reduce_flakiness_in_the_ci branch from 799175a to ef1c40f Compare March 14, 2025 13:39
@sfauvel sfauvel force-pushed the sfa/2360/reduce_flakiness_in_the_ci branch from ef1c40f to 589549b Compare March 14, 2025 13:58
@sfauvel sfauvel temporarily deployed to testing-preview March 14, 2025 14:07 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the sfa/2360/reduce_flakiness_in_the_ci branch from 589549b to 5b03fe5 Compare March 14, 2025 14:18
@sfauvel sfauvel marked this pull request as ready for review March 14, 2025 14:19
@sfauvel sfauvel requested review from jpraynaud, Alenar and dlachaume and removed request for jpraynaud and Alenar March 14, 2025 14:19
@sfauvel sfauvel force-pushed the sfa/2360/reduce_flakiness_in_the_ci branch from 5b03fe5 to e57806f Compare March 14, 2025 14:25
@sfauvel sfauvel temporarily deployed to testing-preview March 14, 2025 14:34 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 🚀

@sfauvel sfauvel temporarily deployed to testing-preview March 17, 2025 11:19 — with GitHub Actions Inactive
* mithril-aggregator from `0.7.14` to `0.7.15`
* mithril-common from `0.5.11` to `0.5.12`
@sfauvel sfauvel temporarily deployed to testing-preview March 17, 2025 13:36 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 308e827 into main Mar 17, 2025
37 checks passed
@sfauvel sfauvel deleted the sfa/2360/reduce_flakiness_in_the_ci branch March 17, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some unit tests in the CI are flaky
4 participants