-
Notifications
You must be signed in to change notification settings - Fork 44
Reduce flakiness in the ci #2370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
799175a
to
ef1c40f
Compare
ef1c40f
to
589549b
Compare
589549b
to
5b03fe5
Compare
…he current function path
5b03fe5
to
e57806f
Compare
jpraynaud
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
dlachaume
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Alenar
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥 🚀
* mithril-aggregator from `0.7.14` to `0.7.15` * mithril-common from `0.5.11` to `0.5.12`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
The flakiness comes from the use of the same temporary directory by different tests.
This PR includes:
temp_dir
that return a temporary path build from the current function pathtemp_dir_create
that create and return a temporary path build from the current function pathnew_sample
to indicate the snapshot directory.initialize_dependencies
that call the function with current module and current function name.initialize_dependencies
function to useinitialize_dependencies!
macro.new_sample
to pass a temporary path generated usingtemp_dir!
Pre-submit checklist
Issue(s)
Closes #2360