Skip to content

Fix: Hydra CI fails with OpenSSL error (Linux x86_64) #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Mar 4, 2025

Content

​This PR includes a fix for the Hydra CI fails with Nix systems due to a regression introduced in the native-tls crate version 0.2.13 (released on January 25).
A fix was release with version 0.2.14 (released on February 19).

Our cargo update on February 5 included the problematic version, leading to errors when loading OpenSSL paths if they were invalid. This caused failures on Nix systems.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2295

Copy link

github-actions bot commented Mar 4, 2025

Test Results

    3 files  ±0     55 suites  ±0   10m 25s ⏱️ ±0s
1 683 tests ±0  1 683 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 075 runs  ±0  2 075 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 362aa3f. ± Comparison against base commit 8695cc0.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the ensemble/2295/fix-hydra-ci-openssl-error branch from c36225f to 6cec6ba Compare March 5, 2025 08:24
@dlachaume dlachaume temporarily deployed to testing-preview March 5, 2025 08:33 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the ensemble/2295/fix-hydra-ci-openssl-error branch from 0338a42 to 33eb4a2 Compare March 5, 2025 10:12
@dlachaume dlachaume temporarily deployed to testing-preview March 5, 2025 10:30 — with GitHub Actions Inactive
@dlachaume dlachaume self-assigned this Mar 5, 2025
@dlachaume dlachaume marked this pull request as ready for review March 5, 2025 10:54
update v0.2.13 -> v0.2.14
@dlachaume dlachaume force-pushed the ensemble/2295/fix-hydra-ci-openssl-error branch from 74fb11d to 232aedd Compare March 5, 2025 10:55
@dlachaume dlachaume temporarily deployed to testing-preview March 5, 2025 11:04 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume temporarily deployed to testing-preview March 5, 2025 15:09 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 83c1357 into main Mar 5, 2025
37 checks passed
@dlachaume dlachaume deleted the ensemble/2295/fix-hydra-ci-openssl-error branch March 5, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra CI fails with OpenSSL error on Linux x86_64 runners
4 participants