Feat: improve disk space calculation for Incremental DB Restoration #2345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Base automatically changed from
sfa/2291/enhance_artifact_structure_for_incremental_cardano_db
to
main
March 4, 2025 10:08
dlachaume
force-pushed
the
dlachaume/2292/enhance-computation-required-disk-space-client-cli
branch
from
69afdfb to
f05b4d6
Compare
jpraynaud
reviewed
Mar 4, 2025
dlachaume
had a problem deploying
to
testing-preview
GitHub Actions
Failure
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
-- Enhance required disk space with margin computation -- Enhance test stability to handle minor rounding differences
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
…he total immutables restored size
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
… dedicated function
* mithril-client-cli from `0.11.6` to `0.11.7`
dlachaume
force-pushed
the
dlachaume/2292/enhance-computation-required-disk-space-client-cli
branch
from
148e8aa to
3197a4a
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
deleted the
dlachaume/2292/enhance-computation-required-disk-space-client-cli
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes enhancements to the disk space computation for incremental Cardano DB snapshot restoration in the client CLI.
It leverages updated artifact metadata to compute the required disk space for both full and partial restorations, adding ancillary files sizes when necessary.
Additionally, for partial restorations, a 10% safety margin is applied to ensure that sufficient disk space is available before download, as the computation uses the average size of an immutable file.
Pre-submit checklist
Issue(s)
Closes #2292