-
Notifications
You must be signed in to change notification settings - Fork 44
Feat: GcpUploader
implements synchronization for Cardano database artifacts
#2233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: GcpUploader
implements synchronization for Cardano database artifacts
#2233
Conversation
Test Results 4 files ±0 52 suites ±0 10m 28s ⏱️ +27s Results for commit 0b9c42e. ± Comparison against base commit daef906. This pull request removes 3 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
9bd86a1
to
75c02e0
Compare
75c02e0
to
441db86
Compare
…er', 'DigestFileUploader' and 'ImmutableFilesUploader' traits
ac0ff14
to
e666011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/digest.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/ancillary.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/immutable.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/immutable.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some test simplification seems possible and there is some questions about error context
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/ancillary.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/ancillary.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/digest.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/digest.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/digest.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* mithril-aggregator from `0.6.13` to `0.6.14`
5ef3791
to
0b9c42e
Compare
Content
This PR includes the update of the
GcpUploader
to support synchronization of Cardano database artifacts.Pre-submit checklist
Issue(s)
Closes #2211