Skip to content

Feat: GcpUploader implements synchronization for Cardano database artifacts #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 17, 2025

Content

This PR includes the update of the GcpUploader to support synchronization of Cardano database artifacts.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2211

Copy link

github-actions bot commented Jan 17, 2025

Test Results

    4 files  ±0     52 suites  ±0   10m 28s ⏱️ +27s
1 531 tests +6  1 531 ✅ +6  0 💤 ±0  0 ❌ ±0 
1 787 runs  +6  1 787 ✅ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 0b9c42e. ± Comparison against base commit daef906.

This pull request removes 3 and adds 9 tests. Note that renamed tests count towards both.
mithril-aggregator ‑ dependency_injection::builder::tests::create_cardano_database_artifact_builder_creates_cardano_database_and_ancillary_directories_in_snapshot_directory
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::get_location_not_using_cdn_domain_return_google_api_uri
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::get_location_using_cdn_domain_return_cdn_in_uri
mithril-aggregator ‑ dependency_injection::builder::tests::build_cardano_database_artifact_builder_creates_cardano_database_and_ancillary_directories_in_snapshot_directory
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_fails_when_file_exists_fails_and_without_overwriting_allowed
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_fails_when_make_public_fails
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_fails_when_upload_fails
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_succeeds_when_file_does_not_exist_remotely_and_without_overwriting_allowed
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_succeeds_when_file_exists_remotely_and_without_overwriting_allowed
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_succeeds_with_overwriting_allowed
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::gcp_backend_uploader::get_location_not_using_cdn_domain_return_google_api_uri
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::gcp_backend_uploader::get_location_using_cdn_domain_return_cdn_in_uri

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 17, 2025 17:27 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2211-artifact-gcp-synchro-cardano-database branch from 9bd86a1 to 75c02e0 Compare January 17, 2025 17:27
@jpraynaud jpraynaud force-pushed the jpraynaud/2211-artifact-gcp-synchro-cardano-database branch from 75c02e0 to 441db86 Compare January 17, 2025 17:30
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 17, 2025 17:40 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 20, 2025 09:01 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2211-artifact-gcp-synchro-cardano-database branch from ac0ff14 to e666011 Compare January 20, 2025 11:08
@jpraynaud jpraynaud marked this pull request as ready for review January 20, 2025 11:16
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 20, 2025 11:16 — with GitHub Actions Inactive
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Some test simplification seems possible and there is some questions about error context

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud force-pushed the jpraynaud/2211-artifact-gcp-synchro-cardano-database branch from 5ef3791 to 0b9c42e Compare January 21, 2025 14:11
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 21, 2025 14:21 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 98407cd into main Jan 21, 2025
43 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2211-artifact-gcp-synchro-cardano-database branch January 21, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement artifacts cloud synchronization in Incremental Cardano DB with GCP
4 participants