Skip to content

Greg/221/certificate store #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2022
Merged

Greg/221/certificate store #222

merged 3 commits into from
May 31, 2022

Conversation

ghubertpalo
Copy link
Collaborator

add a certificate store

@ghubertpalo ghubertpalo requested review from jpraynaud and Alenar and removed request for jpraynaud May 30, 2022 14:32
@github-actions
Copy link

github-actions bot commented May 30, 2022 •
edited
Loading

Unit Test Results

    5 files  ±0    14 suites  ±0   2m 55s ⏱️ +43s
158 tests +6  158 ✔️ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 465bf7b. ± Comparison against base commit 430747f.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo requested a review from jpraynaud May 31, 2022 07:40
jpraynaud
jpraynaud approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo merged commit d011bbb into main May 31, 2022
@ghubertpalo ghubertpalo deleted the greg/221/certificate_store branch May 31, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Awaiting requested review from Alenar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghubertpalo @jpraynaud