Skip to content

Common: Extract a Digester trait from the ImmutableDigester #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2022
Merged

Common: Extract a Digester trait from the ImmutableDigester #218

merged 1 commit into from
May 30, 2022

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented May 30, 2022

... So we can mock it easily

Relates to #176 & #180

@Alenar Alenar requested a review from jpraynaud May 30, 2022 09:26
jpraynaud
jpraynaud approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

github-actions bot commented May 30, 2022 •
edited
Loading

Unit Test Results

    5 files  ±0    14 suites  ±0   2m 20s ⏱️ +9s
134 tests +1  134 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 5bdc266. ± Comparison against base commit ccfb864.

This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both. 
immutable_digester::tests ‑ list_immutable_file_should_skip_last_number
immutable_digester::tests ‑ list_immutable_file_should_works_in_a_empty_folder
immutable_digester::tests ‑ reports_progress_every_5_percent

digesters::immutable_digester::tests ‑ list_immutable_file_should_skip_last_number
digesters::immutable_digester::tests ‑ list_immutable_file_should_works_in_a_empty_folder
digesters::immutable_digester::tests ‑ reports_progress_every_5_percent
src/digesters/digester.rs - digesters::digester ‑ Digester (line 29)

♻️ This comment has been updated with latest results.

@Alenar Alenar force-pushed the djo/176-extract_digester_trait branch from b32461a to 5bdc266 Compare May 30, 2022 09:28
@Alenar Alenar merged commit 20674f5 into main May 30, 2022
@Alenar Alenar deleted the djo/176-extract_digester_trait branch May 30, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alenar @jpraynaud