fix(ci): fix generation of swagger-ui page #2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #2062 the version of our openapi file is `3.1.1` but the action that we use (`Legion2/swagger-ui-action@v1`) is configured by default to use swaggerui version 3 or up and swagger ui is only compatible with openapi 3.1 since version 5.
jpraynaud
approved these changes
Nov 25, 2024
dlachaume
approved these changes
Nov 25, 2024
sfauvel
approved these changes
Nov 25, 2024
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR fixes our swagger ui page, https://mithril.network/openapi-ui/, that has been broken since merging #2062:
The faulty PR modified the version of our openapi file to
3.1.1, but the action that we use (Legion2/swagger-ui-action@v1) is configured by default to use swagger ui version 3 or up, said swagger ui is only compatible with openapi3.1since version 5.Pre-submit checklist