Client wasm multiple targets #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
ensemble/2091/client-wasm-multiple-targets
branch
from
673e990 to
fe8b486
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
force-pushed
the
ensemble/2091/client-wasm-multiple-targets
branch
from
eb13b9e to
1dd0dfb
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
force-pushed
the
ensemble/2091/client-wasm-multiple-targets
branch
from
1dd0dfb to
2e46884
Compare
Alenar
force-pushed
the
ensemble/2091/client-wasm-multiple-targets
branch
from
2e46884 to
347430d
Compare
+ adapt www, www-test, and explorer `package.json` and upgrade their dependencies Co-authored-by: Damien Lachaume <dlachaume@users.noreply.github.com>
Co-authored-by: Damien Lachaume <dlachaume@users.noreply.github.com>
- Move nodejs & web browser examples to the `/examples` directory - Standardize them: add a README and a MAKEFILE when missing - Rename `mithril-client-wasm/www-test` to `ci-test` - adapt ci - adapt upgrade repository dependencies devbook Co-authored-by: Damien Lachaume <dlachaume@users.noreply.github.com>
Co-authored-by: Damien Lachaume <dlachaume@users.noreply.github.com>
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
force-pushed
the
ensemble/2091/client-wasm-multiple-targets
branch
from
347430d to
b0936ca
Compare
by targetting explicitly the web package, else NextJs want to target both the node package for it's Server side rendering and the web package for the client side. It then fail to find the node package and fallback to client rendering with an error. Co-authored-by: Damien Lachaume <dlachaume@users.noreply.github.com>
Co-authored-by: Damien Lachaume <dlachaume@users.noreply.github.com>
Alenar
force-pushed
the
ensemble/2091/client-wasm-multiple-targets
branch
from
b0936ca to
773eb19
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
As previous version `8.57.1` is now deprecated
* mithril-client-wasm from `0.6.1` to `0.7.0` * [js] mithril-client-wasm from `0.6.1` to `0.6.2` * [js] mithril-explorer from `0.7.18` to `0.7.19` Co-authored-by: Damien Lachaume <dlachaume@users.noreply.github.com>
Co-authored-by: Damien Lachaume <dlachaume@users.noreply.github.com>
Alenar
force-pushed
the
ensemble/2091/client-wasm-multiple-targets
branch
from
773eb19 to
9e8e19e
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR rework our npm published
mithril-client-wasmpackage in order to include multiple targets (node, web, bundler) instead of only the web target.This allow Node.Js users to use our published package instead of needing to manually build a package.
This works by defining manually a
package.jsonto aggregates built wasm-pack targets into a single package.Inside it we set the
mainand thebrowserentrypoints so child projects can automatically choose the relevant targets between node and web meaning that existing client should not needs any change.Note
Some clients that use mixed projects types (typically that use SSR, ie: NextJs) can have trouble with the automatic detection, in this case they can target a specific package in their
package.jsonExample to target directly the
webpackage:todo: update wasm readme (compat table and fallbacks).
Pre-submit checklist
Issue(s)
Closes #2091