-
Notifications
You must be signed in to change notification settings - Fork 44
Refactor signer pruning with upkeep service #2108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor signer pruning with upkeep service #2108
Conversation
Test Results 4 files ±0 51 suites ±0 11m 5s ⏱️ +21s Results for commit d9ca627. ± Comparison against base commit 0a7fb9f. This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
* mithril-persistence from `0.2.32` to `0.2.33` * mithril-signer from `0.2.211` to `0.2.212`
4e5fbe0
to
d9ca627
Compare
Content
This PR remove the pruning from the save function and use the upkeep service instead.
The
StakeStore
is moved frompersistence
tosigner
.The
EpochPruningTask
is implemented over theStorePruner
in the Signer for theProtocolInitializerStore
andStakeStore
.Pre-submit checklist
Issue(s)
Closes #2075