Skip to content

Mithril Aggregator produces certificates #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 25, 2022

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented May 23, 2022

Implements real Certificate with:

  • Adds automatic Hash computation for Certificate
  • Adds Aggregate Verification Key (AVK) to Certificate:
    • Fix AVK serialization in mithril-core library
    • Allows removing usage of a Clerk in the Mithril Client
    • Reduces footprint of the stake distribution by including only signers of the multisignature
  • Prepares the implementation of the Certificate and CertificatePending stores (see add generic adapters #211)
  • A bit of cleanup

Relates to #179

@github-actions
Copy link

github-actions bot commented May 23, 2022

Unit Test Results

    5 files  ±0    14 suites  ±0   2m 36s ⏱️ +19s
129 tests +2  129 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit 10d3e26. ± Comparison against base commit e841dd3.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/179-produce-certificates branch from f6554ca to 7a0eb7d Compare May 23, 2022 18:58
@jpraynaud jpraynaud force-pushed the jpraynaud/179-produce-certificates branch from 7a0eb7d to 60266da Compare May 24, 2022 08:12
jpraynaud added 4 commits May 24, 2022 12:07
* Add 'aggregate_verification_key' field to certificate
* Add 'hash' computation in factory
* Compute aggregate verification key with multisignature
* Cleanup code before implementing real stores
@jpraynaud jpraynaud force-pushed the jpraynaud/179-produce-certificates branch from d7ea849 to 77c5285 Compare May 24, 2022 14:48
jpraynaud added 2 commits May 24, 2022 17:53
* Implements the 'aggregate_verification_key' from certificate to validate multisignature
* Done some cleanup with types
@jpraynaud jpraynaud marked this pull request as ready for review May 24, 2022 16:35
@jpraynaud jpraynaud requested review from Alenar, iquerejeta, ghubertpalo and a user May 24, 2022 16:50
@jpraynaud jpraynaud merged commit 6e2c311 into main May 25, 2022
@jpraynaud jpraynaud deleted the jpraynaud/179-produce-certificates branch May 25, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants