Skip to content

Aggregator: Local snapshot store #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 23, 2022
Merged

Aggregator: Local snapshot store #203

merged 14 commits into from
May 23, 2022

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented May 18, 2022 •
edited
Loading

see #206

@github-actions
Copy link

github-actions bot commented May 18, 2022 •
edited
Loading

Unit Test Results

    5 files  ±  0    14 suites  ±0   2m 14s ⏱️ -8s
127 tests +14  127 ✔️ +14  0 💤 ±0  0 ❌ ±0 

Results for commit 8a6d027. ± Comparison against base commit bad8d94.

This pull request removes 5 and adds 19 tests. Note that renamed tests count towards both. 
snapshot_store::tests ‑ test_get_snapshot_details_ko_500
snapshot_store::tests ‑ test_get_snapshot_details_ok
snapshot_store::tests ‑ test_list_snapshots_ko_500
snapshot_store::tests ‑ test_list_snapshots_ko_unreachable
snapshot_store::tests ‑ test_list_snapshots_ok

http_server::tests ‑ test_snapshot_download_get_ko
http_server::tests ‑ test_snapshot_download_get_ok
http_server::tests ‑ test_snapshot_download_get_ok_nosnapshot
snapshot_stores::local_snapshot_store::tests ‑ can_get_added_snapshot_details
snapshot_stores::local_snapshot_store::tests ‑ can_list_added_snapshot
snapshot_stores::remote_snapshot_store::tests ‑ test_add_snapshot_ko
snapshot_stores::remote_snapshot_store::tests ‑ test_add_snapshot_ok
snapshot_stores::remote_snapshot_store::tests ‑ test_get_snapshot_details_ko_500
snapshot_stores::remote_snapshot_store::tests ‑ test_get_snapshot_details_ok
snapshot_stores::remote_snapshot_store::tests ‑ test_list_snapshots_ko_500
…

♻️ This comment has been updated with latest results.

@Alenar Alenar force-pushed the djo/180-local-snapshot-store branch 6 times, most recently from fbf6769 to 45a2313 Compare May 20, 2022 17:52
@Alenar Alenar marked this pull request as ready for review May 20, 2022 17:52
@Alenar Alenar force-pushed the djo/180-local-snapshot-store branch 3 times, most recently from 41e4156 to 8a6d027 Compare May 23, 2022 08:25
Alenar added 14 commits May 23, 2022 10:56
@Alenar
Move snapshot_store to a dedicated folder
b31702f 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Rename SnapshotStoreHttpClient to GcpSnapshotStore
2f79419 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Fix clippy complaints
603ebc2 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Move snapshot upload code to GcpSnapshotStore
2924071 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Fix naming
59f851c 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Bootstrap local snapshot store
2cded02 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Split snapshot stores & uploaders
8f776fe 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Make the snapshot store & uploader configurable
02cd9bd 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Add tests to new objects
4c5f26b 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Serve snapshot on the http server
ad0d051 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Rename gcp_snapshot(store/uploader) to remote_xxx
7d5adf7 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Fix clippy errors
725d51d 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Reworked config to pass some of the clap parameters
be7591d 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Use network parameter in archive filename
c4ced8e 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar Alenar force-pushed the djo/180-local-snapshot-store branch from 8a6d027 to c4ced8e Compare May 23, 2022 08:56
@Alenar Alenar merged commit e841dd3 into main May 23, 2022
@Alenar Alenar deleted the djo/180-local-snapshot-store branch May 23, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Alenar