Skip to content

Feat: sign epoch in genesis certificate #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 7, 2024

Content

This PR includes the signature of the genesis epoch in the genesis certificate.

Enhancements to CertificateGenesisProducer:

Updates to GenesisTools:

Test updates:

Version updates:

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Test Results

    4 files  ±0     54 suites  ±0   9m 5s ⏱️ -13s
1 331 tests ±0  1 331 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 542 runs  ±0  1 542 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 141e25a. ± Comparison against base commit e4f8e3c.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud force-pushed the jpraynaud/sign-epoch-genesis-certificate branch from 801498c to 141e25a Compare October 8, 2024 09:57
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 8, 2024 10:04 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit ef0c28a into main Oct 8, 2024
43 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/sign-epoch-genesis-certificate branch October 8, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants