Skip to content

Aggregator issues realish beacon #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 17, 2022
Merged

Aggregator issues realish beacon #194

merged 12 commits into from
May 17, 2022

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented May 11, 2022

see #177

@github-actions
Copy link

github-actions bot commented May 11, 2022 •
edited
Loading

Unit Test Results

    6 files  ±0    15 suites  ±0   2m 20s ⏱️ -28s
107 tests +4  107 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 03e0875. ± Comparison against base commit 2423d89.

This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both. 
client::tests ‑ test_restore_snapshot_ko_get_certificate_details
client::tests ‑ test_restore_snapshot_ko_verify_multi_signature
snapshotter::tests ‑ reports_progress_every_5_percent

beacon_store::tests ‑ test_can_store_beacon
beacon_store::tests ‑ test_reset_current_beacon_ok
http_server::tests ‑ test_certificate_pending_get_ko
http_server::tests ‑ test_certificate_pending_get_ok_204
immutable_digester::tests ‑ list_immutable_file_should_skip_last_number
immutable_digester::tests ‑ list_immutable_file_should_works_in_a_empty_folder
immutable_digester::tests ‑ reports_progress_every_5_percent

♻️ This comment has been updated with latest results.

@Alenar Alenar force-pushed the djo/177-aggregator-issues-realish-beacon branch 4 times, most recently from 491cb26 to e50d080 Compare May 11, 2022 18:38
@Alenar Alenar force-pushed the djo/177-aggregator-issues-realish-beacon branch 2 times, most recently from 0e63fac to 4865181 Compare May 13, 2022 16:32
@Alenar Alenar marked this pull request as ready for review May 16, 2022 08:16
@Alenar Alenar force-pushed the djo/177-aggregator-issues-realish-beacon branch from 4865181 to 6f1613d Compare May 16, 2022 08:20
@Alenar Alenar force-pushed the djo/177-aggregator-issues-realish-beacon branch from e612d69 to 40163ae Compare May 17, 2022 08:38
@Alenar Alenar force-pushed the djo/177-aggregator-issues-realish-beacon branch from 40163ae to 60d45d7 Compare May 17, 2022 09:20
jpraynaud and others added 3 commits May 17, 2022 14:46
@jpraynaud
Use real beacon for fake digest
6d594b5
@Alenar
/Certificate/{hash} route returns a beacon instead of a block
f27d364
@jpraynaud
Temporarly remove Client MultiSignature verification
03e0875 
The multi signature verification is temporarily skipped, until the real certificate hash is computed
and stored in a local store instead of in remote manifest file
@jpraynaud jpraynaud force-pushed the djo/177-aggregator-issues-realish-beacon branch from 8483c67 to 03e0875 Compare May 17, 2022 14:24
@Alenar Alenar merged commit 03e0875 into main May 17, 2022
@Alenar Alenar deleted the djo/177-aggregator-issues-realish-beacon branch May 17, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alenar @abailly @jpraynaud