Optional signed message in registered signatures #1909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else we would need to change signatures of multiple methods in the signer in order to pass it to the `RegisterSignnatureMessage`. It will also be usefull in aggregator to handle signature buffer on the service side (since most services use entities instead of messages).
Test Results 4 files ±0 53 suites ±0 9m 18s ⏱️ -7s Results for commit 064aa0a. ± Comparison against base commit cbd65d0. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
* Mithril-aggregator from `0.5.57` to `0.5.58` * Mithril-signer from `0.2.175` to `0.2.176` * Mithril-common from `0.4.47` to `0.4.48` * Mithril-end-to-end from `0.4.29` to `0.4.30`
Alenar
force-pushed
the
djo/1899/optional_signed_message_in_register_signature
branch
from
eb7d638 to
064aa0a
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
deleted the
djo/1899/optional_signed_message_in_register_signature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR add an optional field to single signatures:
signed_message.In order to decentralize signatures orchestration we will need to buffer incoming single signatures when the Aggregator has yet to create an open message for the signed entity type.
But in that case we won't be able to some validation to reject immediately malicious signatures from bad actors.
This new field will allow us to do an integrity check of incoming signatures, by checking their validity against their signed message and the current stake distribution, .
Pre-submit checklist
Issue(s)
Closes #1899