Skip to content

UpkeepService tests flakiness #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2024
Merged

UpkeepService tests flakiness #1802

merged 2 commits into from
Jul 8, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Jul 4, 2024 •
edited
Loading

Content

This PR includes a tentative fix of CI flakiness observed for UpkeepService tests on both aggregator & signer.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@Alenar Alenar force-pushed the djo/flakiness_and_remove_block_in_place branch from 866123d to 60ebddc Compare July 4, 2024 16:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   8m 50s ⏱️ +11s
1 141 tests ±0  1 141 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 307 runs  ±0  1 307 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 96b194a. ± Comparison against base commit 3caf4de.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview July 4, 2024 16:44 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet July 4, 2024 16:44 — with GitHub Actions Inactive
@Alenar Alenar requested review from sfauvel, jpraynaud and dlachaume July 4, 2024 16:49
@Alenar Alenar marked this pull request as ready for review July 8, 2024 08:22
@Alenar Alenar force-pushed the djo/flakiness_and_remove_block_in_place branch from 60ebddc to 4908aa0 Compare July 8, 2024 08:27
@Alenar Alenar changed the title UpkeepService tests flakiness and remove task::block_in_place. UpkeepService tests flakiness Jul 8, 2024
dlachaume
dlachaume approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar temporarily deployed to testing-preview July 8, 2024 08:34 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet July 8, 2024 08:34 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alenar Alenar temporarily deployed to testing-preview July 8, 2024 08:42 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet July 8, 2024 08:42 — with GitHub Actions Inactive
Alenar added 2 commits July 8, 2024 10:45
@Alenar
Attempt to fix CI flakiness for upkeep services tests
e0ddb49 
It seems that the log is not always fully written when the assertion are
run, making them fails.
This should ensure that the logger is dropped, flushin their files,
before the assertions are run.
@Alenar
Upgrade crates versions
96b194a 
* Mithril-aggregator from `0.5.37` to `0.5.38`
* Mithril-signer from `0.2.159` to `0.2.160`
@Alenar Alenar force-pushed the djo/flakiness_and_remove_block_in_place branch from 2b14b4e to 96b194a Compare July 8, 2024 08:46
@Alenar Alenar temporarily deployed to testing-preview July 8, 2024 08:53 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet July 8, 2024 08:53 — with GitHub Actions Inactive
@Alenar Alenar merged commit 9625476 into main Jul 8, 2024
40 of 41 checks passed
@Alenar Alenar deleted the djo/flakiness_and_remove_block_in_place branch July 8, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alenar @sfauvel @jpraynaud @dlachaume