Skip to content

Fix: avoid pool acquire timeout during Cardano transaction prover cache computation #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2024
Merged

Fix: avoid pool acquire timeout during Cardano transaction prover cache computation #1801

merged 2 commits into from
Jul 4, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 4, 2024 •
edited
Loading

Content

This PR includes a fix to avoid some timeout occurring when trying to acquire a Merkle map from the resource pool when it is being refreshed.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1793

@jpraynaud jpraynaud self-assigned this Jul 4, 2024
@jpraynaud jpraynaud changed the title fix: avoid pool acquire timeout during Cardano transaction prover cache computation Fix: avoid pool acquire timeout during Cardano transaction prover cache computation Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   8m 47s ⏱️ -12s
1 141 tests ±0  1 141 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 307 runs  ±0  1 307 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1c8eb41. ± Comparison against base commit e38d6b7.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview July 4, 2024 13:58 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 4, 2024 13:58 — with GitHub Actions Inactive
@jpraynaud jpraynaud requested review from Alenar and sfauvel July 4, 2024 14:00
@jpraynaud jpraynaud requested a review from dlachaume July 4, 2024 15:20
sfauvel
sfauvel approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud force-pushed the jpraynaud/1793-fix-acquire-pool-timeout-prover branch from d18b90e to 1c8eb41 Compare July 4, 2024 15:57
@jpraynaud jpraynaud temporarily deployed to testing-preview July 4, 2024 16:04 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 4, 2024 16:04 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 3caf4de into main Jul 4, 2024
40 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1793-fix-acquire-pool-timeout-prover branch July 4, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource Pool acquire timeout when being updated
4 participants
@jpraynaud @Alenar @sfauvel @dlachaume