Skip to content

Fix sanchonet blocks parsing #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 2, 2024

Content

This PR includes a fix to some blocks not being correctly parsed by pallas 0.27.0.
The fix is included with the upgrade to pallas 0.28.0.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1750

From '0.27.0' to '0.28.0'.
@jpraynaud jpraynaud self-assigned this Jul 2, 2024
@jpraynaud jpraynaud requested review from Alenar, sfauvel and dlachaume July 2, 2024 07:41
Copy link

github-actions bot commented Jul 2, 2024

Test Results

    4 files  ±0     51 suites  ±0   8m 50s ⏱️ ±0s
1 101 tests ±0  1 101 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 249 runs  ±0  1 249 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a254088. ± Comparison against base commit 4409ebb.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview July 2, 2024 07:48 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 2, 2024 07:48 — with GitHub Actions Inactive
- 'mithril-common' from '0.4.23' to '0.4.24'
- 'mithril-aggregator' from '0.5.31' to '0.5.32'
- 'mithril-signer' from '0.2.154. yo '0.2.155'.
@jpraynaud jpraynaud force-pushed the jpraynaud/1750-fix-sanchonet-blocks-parsing branch from 15f7686 to a254088 Compare July 2, 2024 09:23
@jpraynaud jpraynaud temporarily deployed to testing-preview July 2, 2024 09:30 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 2, 2024 09:30 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 5816ed4 into main Jul 2, 2024
43 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1750-fix-sanchonet-blocks-parsing branch July 2, 2024 09:37
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants