Skip to content

Dev blog post for removed snapshot command in client CLI #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

Dev blog post for removed snapshot command in client CLI #1746

merged 1 commit into from
Jun 12, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 12, 2024 •
edited
Loading

Content

This PR includes a new dev blog post about the removed snapshot command from the Mithril client CLI.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Add dev blog post (if relevant)

Issue(s)

Relates to #1695

@jpraynaud jpraynaud self-assigned this Jun 12, 2024
dlachaume
dlachaume approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Test Results

    3 files  ±0     43 suites  ±0   8m 37s ⏱️ -8s
1 035 tests ±0  1 035 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 133 runs  ±0  1 133 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit becb0c0. ± Comparison against base commit dc9f5f9.

@jpraynaud jpraynaud temporarily deployed to testing-preview June 12, 2024 08:36 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet June 12, 2024 08:36 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 0c3ee09 into main Jun 12, 2024
41 of 43 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1695-blog-client-cli-deprecated-snapshot-command branch June 12, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@dlachaume dlachaume dlachaume approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpraynaud @Alenar @dlachaume