Skip to content

Update BlockStreamer return type #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2024
Merged

Update BlockStreamer return type #1716

merged 4 commits into from
May 28, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented May 27, 2024 •
edited
Loading

Content

This PR includes a modification of the BlockStreamer trait to be able to handle rollbacks.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1704

@dlachaume dlachaume changed the title Ensemble/modify block streamer return type Handle rollbacks with BlockStreamer May 27, 2024
@dlachaume dlachaume requested review from Alenar and jpraynaud May 27, 2024 16:40
@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

Test Results

    3 files  ±0     43 suites  ±0   8m 31s ⏱️ -7s
  991 tests ±0    991 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 089 runs  ±0  1 089 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 06ce18e. ± Comparison against base commit 1dd6495.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview May 27, 2024 16:45 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 27, 2024 16:45 — with GitHub Actions Inactive
@dlachaume dlachaume changed the title Handle rollbacks with BlockStreamer Update BlockStreamer return type May 28, 2024
jpraynaud
jpraynaud approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the ensemble/modify-block-streamer-return-type branch from 0a269d3 to 06ce18e Compare May 28, 2024 10:09
@dlachaume dlachaume temporarily deployed to testing-preview May 28, 2024 10:16 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 28, 2024 10:16 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 8b66e45 into main May 28, 2024
40 of 41 checks passed
@dlachaume dlachaume deleted the ensemble/modify-block-streamer-return-type branch May 28, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@sfauvel sfauvel

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block Streamer returns ChainScannedBlocks
4 participants
@dlachaume @Alenar @jpraynaud @sfauvel