Skip to content

Remove snapshot command #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 27, 2024
Merged

Remove snapshot command #1710

merged 17 commits into from
May 27, 2024

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented May 23, 2024 •
edited
Loading

Content

This PR remove snapshotcommand from Mithril client cli.

Initial behavior:
image

New behavior:
image

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Closes #1690

github-advanced-security[bot]
github-advanced-security bot found potential problems May 23, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

Test Results

    3 files  ±0     43 suites  ±0   8m 30s ⏱️ +9s
  987 tests +2    987 ✅ +2  0 💤 ±0  0 ❌ ±0 
1 085 runs  +6  1 085 ✅ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 1aa6623. ± Comparison against base commit 7ee2ee0.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel marked this pull request as ready for review May 23, 2024 16:28
jpraynaud
jpraynaud approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I left few comments below.

@sfauvel sfauvel temporarily deployed to testing-preview May 24, 2024 09:52 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet May 24, 2024 09:52 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-preview May 24, 2024 10:17 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet May 24, 2024 10:17 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the ensemble/1690/remove_snapshot_command branch from f207249 to e75f93e Compare May 27, 2024 08:21
@sfauvel sfauvel force-pushed the ensemble/1690/remove_snapshot_command branch from e75f93e to 1aa6623 Compare May 27, 2024 08:30
@sfauvel sfauvel temporarily deployed to testing-preview May 27, 2024 08:46 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet May 27, 2024 08:46 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 811b07e into main May 27, 2024
41 checks passed
@sfauvel sfauvel deleted the ensemble/1690/remove_snapshot_command branch May 27, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove snapshot command in client CLI
3 participants
@sfauvel @Alenar @jpraynaud