Skip to content

Mithril Signer produces a single signature #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
9 commits merged into from
May 5, 2022
Merged

Mithril Signer produces a single signature #167

9 commits merged into from
May 5, 2022

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented May 4, 2022

see #144 & #145

@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

test-results-mithril-client

  1 files  ±0    1 suites  ±0   0s ⏱️ ±0s
16 tests ±0  16 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d2fe57b. ± Comparison against base commit ee05bd6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

test-results-mithril-aggregator

  1 files  ±0    3 suites  ±0   1s ⏱️ ±0s
26 tests ±0  26 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
35 runs  ±0  35 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d2fe57b. ± Comparison against base commit ee05bd6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

test-results-mithril-core

  2 files  ±0    4 suites  ±0   12m 8s ⏱️ + 1m 37s
35 tests ±0  35 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d2fe57b. ± Comparison against base commit ee05bd6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

test-results-mithril-signer

  1 files  ±  0    1 suites  ±0   0s ⏱️ ±0s
15 tests +15  15 ✔️ +15  0 💤 ±0  0 ❌ ±0 

Results for commit d2fe57b. ± Comparison against base commit ee05bd6.

♻️ This comment has been updated with latest results.

@Alenar Alenar force-pushed the ensemble/144-signer-retrieve-pending-cert branch from 956e259 to 2a8012f Compare May 4, 2022 12:40
@Alenar Alenar force-pushed the ensemble/144-signer-retrieve-pending-cert branch from 2a8012f to 84fae19 Compare May 4, 2022 14:22
@jpraynaud jpraynaud force-pushed the ensemble/144-signer-retrieve-pending-cert branch from 9ee741f to 7f3aae4 Compare May 4, 2022 15:48
@jpraynaud jpraynaud force-pushed the ensemble/144-signer-retrieve-pending-cert branch from 7f3aae4 to d2fe57b Compare May 4, 2022 16:36
@jpraynaud jpraynaud marked this pull request as ready for review May 4, 2022 17:25
@jpraynaud jpraynaud requested review from jpraynaud, a user and ghubertpalo May 4, 2022 17:25
jpraynaud
jpraynaud approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghost ghost merged commit 6a2e8dc into main May 5, 2022
@ghost ghost deleted the ensemble/144-signer-retrieve-pending-cert branch May 5, 2022 02:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alenar @jpraynaud @abailly